Skip to content

Fix invalid URL handling in PyJWKClient.fetch_data() #1130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kontrolix wants to merge 2 commits into
base: master
Choose a base branch
from
+14 −0
Open

Fix invalid URL handling in PyJWKClient.fetch_data() #1130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abaac63
Add error handling for invalid URLs in fetch_data method
Kontrolix Jan 30, 2026
cdbc59e
fix: correct test method name for invalid URL handling
Kontrolix Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions jwt/jwks_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,10 @@ def fetch_data(self) -> Any:
jwk_set: Any = None
try:
r = urllib.request.Request(url=self.uri, headers=self.headers)
except ValueError as e:
raise PyJWKClientError(f'Invalid URL "{self.uri}", err: "{e}"') from e

try:
with urllib.request.urlopen(
r, timeout=self.timeout, context=self.ssl_context
) as response:
Expand Down
10 changes: 10 additions & 0 deletions tests/test_jwks_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,3 +357,13 @@ def test_get_jwt_set_sslcontext_no_ca(self):
)
with pytest.raises(PyJWKClientError):
jwks_client.get_jwk_set()

def test_fetch_data_invalid_url(self):
url = "obviously_wrong_url"

jwks_client = PyJWKClient(url)

with pytest.raises(PyJWKClientError) as exc:
jwks_client.fetch_data()

assert f'Invalid URL "{url}"' in str(exc.value)
Loading