Skip to content

Conversation

@Divan009
Copy link
Contributor

@Divan009 Divan009 commented Oct 1, 2024

new pr #1005

  • Added validation logic for both the 'sub' (subject) and 'jti' (JWT ID) claims.
  • Introduced _validate_sub and _validate_jti methods for verifying these claims.
  • Updated the decode_complete function to include options for verifying the 'sub' and 'jti' claims.
  • Update the positional arguments in decode and decode_complete function, to accept subject

Copy link
Owner

@jpadilla jpadilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, can you please make sure there's test coverage in place for these changes?

@jpadilla jpadilla added the hacktoberfest Issues for first-time contributors label Oct 8, 2024
@Divan009 Divan009 marked this pull request as draft October 8, 2024 04:21
@Divan009
Copy link
Contributor Author

Divan009 commented Oct 8, 2024

thanks, can you please make sure there's test coverage in place for these changes?

Will do.

Update: @jpadilla Added the test cases

@Divan009 Divan009 marked this pull request as ready for review October 8, 2024 16:34
@Divan009 Divan009 requested a review from jpadilla October 8, 2024 16:41
Copy link
Owner

@jpadilla jpadilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you update the changeling?

@Divan009
Copy link
Contributor Author

Divan009 commented Oct 10, 2024

@jpadilla No problem! Updated it 😺

@Divan009 Divan009 closed this by deleting the head repository Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest Issues for first-time contributors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants