Ldesign media 86c4x1jjq merge users#393
Conversation
…gnMedia/moodle-tool_mergeusers into LdesignMedia-86c4x1jjq-merge-users # Conflicts: # version.php
Added comprehensive tests to verify that merge events (success and failure) are correctly triggered when merging users via adhoc task execution.
…ontent Added tests to verify that correct notifications (success/error) are sent with appropriate content when adhoc task completes with different results.
… according to the Moodle coding guidelines.
… according to the Moodle coding guidelines.
|
Hi @jpahullo, We have implemented all the feedback points. Kindly check and let us know if all good. CC: @luukverhoeven |
|
Thanks for working on this issue @nihaalshaikh and @luukverhoeven ! I am allowing to run the CI. Let's see its result. These days are being very busy on my side. I cannot be sure I could review it this week or so. Thanks, Jordi |
|
Hi Jordi (@jpahullo), No rush, just a friendly reminder so it doesn’t get lost. When you have a moment, could you please drop a quick note here once you’ve had a chance to look it over (or if anything is blocking you)? Thanks! |
|
Thanks @luukverhoeven for the patience. I will try these Christmas days my best on my spare time, so I could provide a new version including your changes. In my working time there is no priority for this plugin right now, so this is why this interesting contribution does not get more love from me. Thanks a lot for your work, sincerely. Regards and Merry Christmas, Jordi |
|
Thank you for making time to work on this despite your busy schedule. I really appreciate your efforts and wish you a wonderful Christmas as well. |
|
Hi all, Finally, I could not face anything this Christmas time: illness on my family members made me impossible to address this review and so. Hopefully next days I will be able to check it properly. Thanks for the patience. Jordi |
|
Hi @jpahullo , Sorry to hear that. But I hope that they are doing better now. Did you get time to have a look at this? CC: @luukverhoeven |
|
Hi @nihaalshaikh and @luukverhoeven , Sorry. I cannot manage to check this PR yet. We are very busy at work and there is no window time planned for this. I cannot say anything more concrete. I will try to do my best to get it in asap. Thanks for your words and sorry for the inconvenience. All the best, Jordi |
nihaalshaikh
force-pushed
the
LdesignMedia-86c4x1jjq-merge-users
branch
from
8436c5a to
88e2c38
Compare
3 participants
No description provided.