Skip to content

Fix CMake policy CMP0175 warning and improve test documentation #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
colinrlim wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix CMake policy CMP0175 warning and improve test documentation #162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74cc422
Fix CMake policy CMP0175 warning in ADD_CUSTOM_COMMAND
colinrlim Oct 21, 2025
419cf49
Document test behavior and reference image generation
colinrlim Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,10 +223,11 @@ IF(GLSLC AND XXD)
FOREACH(shad_spv ${SHADER_OUTPUTS})
GET_FILENAME_COMPONENT(SPV ${shad_spv} NAME)
ADD_CUSTOM_COMMAND (
TARGET BuildShadersHeader
WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/${SHADER_DIR}
COMMAND ${XXD} -i ${SPV} >> ${SHADERS_H}
)
TARGET BuildShadersHeader
POST_BUILD
WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/${SHADER_DIR}
COMMAND ${XXD} -i ${SPV} >> ${SHADERS_H}
)
ENDFOREACH()
SET_SOURCE_FILES_PROPERTIES(${SHADERS_H} PROPERTIES GENERATED 1)
#add_definitions( -DDEBUG_VK_PERF=true )
Expand Down
14 changes: 14 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,20 @@ In general, we follow the ["fork-and-pull" Git workflow](https://github.com/susa
6. Push changes to your fork
7. Open a PR in our repository and follow the PR template so that we can efficiently review the changes.

### Testing

To build and run unit tests:
```bash
cd vkvg
mkdir build
cd build
cmake ..
make
./gunit_tests/unit_tests
```

**Note**: Visual regression tests will skip on first run to generate reference images in `ReferenceImages/`. Subsequent runs compare against these baselines.

## Getting Help

Join us on [gitter](https://gitter.im/CSharpRapidOpenWidgets).