Change tests to use throwables instead of class references in tests#3
Open
grahampacker-ms wants to merge 2 commits intojpgough:mainfrom
Open
Change tests to use throwables instead of class references in tests#3grahampacker-ms wants to merge 2 commits intojpgough:mainfrom
grahampacker-ms wants to merge 2 commits intojpgough:mainfrom
Conversation
grahampacker-ms
force-pushed
the
degenerify-tests
branch
from
abea0da to
9888b1f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the approach to the tests so they use Throwables instead of class references. This seems to fix the issues with mocking and also allowed me to enable the disabled tests