Dockerfile and webproc upgrades - #40
Open
thetredev wants to merge 14 commits into
Open
Conversation
Signed-off-by: Timo Reichl <thetredev@gmail.com>
Signed-off-by: Timo Reichl <thetredev@gmail.com>
Signed-off-by: Timo Reichl <thetredev@gmail.com>
Signed-off-by: Timo Reichl <thetredev@gmail.com>
Signed-off-by: Timo Reichl <thetredev@gmail.com>
Signed-off-by: Timo Reichl <thetredev@gmail.com>
ENV instructions create new layers, whereas ARG instructions do not. Signed-off-by: Timo Reichl <thetredev@gmail.com>
Signed-off-by: Timo Reichl <thetredev@gmail.com>
This could result in unexpected behavior due to package upgrades that we aren't tracking. Signed-off-by: Timo Reichl <thetredev@gmail.com>
Signed-off-by: Timo Reichl <thetredev@gmail.com>
Signed-off-by: Timo Reichl <thetredev@gmail.com>
Signed-off-by: Timo Reichl <thetredev@gmail.com>
Signed-off-by: Timo Reichl <thetredev@gmail.com>
Signed-off-by: Timo Reichl <thetredev@gmail.com>
Owner
|
Thanks! Main thing I’ve wanted to do is bump dnsmasq though many years ago
I only published latest; so any changes will potentially go out to many
thousands of users
I think the fix is to not touch latest…
…On Wed, 28 Jan 2026 at 7:40 am, Timo Reichl ***@***.***> wrote:
Don't know if this project is still active, but here goes my changes in a
nutshell:
- Pin the Alpine base image version
- Bump webproc to release 0.4.0
- Modernize Dockerfile
- Get rid of unnecessary Docker build dependencies
- Reduce container image layers to a minimum
- Transform the maintainer LABEL Dockerfile instruction into the
correct/supported/expected syntax (
https://docs.docker.com/reference/dockerfile/#maintainer-deprecated)
- Add myself to the maintainer & copyright holders list
- The Docker context resides in the directory image, and image/rootfs
contains all the files that should be copied into the container image we
are building
No CI/CD stuff as of yet. This is just to modernize/modularize/standardize
things.
------------------------------
You can view, comment on, or merge this pull request online at:
#40
Commit Summary
- 8dabdde
<8dabdde>
dockerfile: update maintainer metadata instruction
- 71c9a31
<71c9a31>
add myself to the list of authors and copyright holders
- dc7f916
<dc7f916>
dockerfile: pin alpine release
- 9a422b6
<9a422b6>
move dockerfile into image/ directory
- 243ddc6
<243ddc6>
dockerfile: cosmetic changes
- 3d4bbc3
<3d4bbc3>
docker: move container image rootfs files into image/rootfs/ directory
- 6e2dd4a
<6e2dd4a>
dockerfile: use ARG instructions for WEBPROC_VERSION and WEBPROC_URL
- a629faa
<a629faa>
dockerfile: link the rootfs COPY instruction to the previous RUN layer
- c51bfb9
<c51bfb9>
dockerfile: do not upgrade the base image using 'apk upgrade'
- b2fb757
<b2fb757>
dockerfile: replace tabs with spaces
- 3156b95
<3156b95>
dockerfile: replace single-command RUN instruction with heredoc string
- 31b2762
<31b2762>
bump jpillora/webproc to 0.4.0
- fcb497c
<fcb497c>
dockerfile: get rid of curl build dependency
- 653abee
<653abee>
dockerfile: put base image & webproc release settings on top of the file
File Changes
(7 files <https://github.com/jpillora/docker-dnsmasq/pull/40/files>)
- *D* Dockerfile
<https://github.com/jpillora/docker-dnsmasq/pull/40/files#diff-dd2c0eb6ea5cfc6c4bd4eac30934e2d5746747af48fef6da689e85b752f39557>
(18)
- *M* LICENSE
<https://github.com/jpillora/docker-dnsmasq/pull/40/files#diff-c693279643b8cd5d248172d9c22cb7cf4ed163a3c98c8a3f69c2717edd3eacb7>
(1)
- *M* README.md
<https://github.com/jpillora/docker-dnsmasq/pull/40/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5>
(3)
- *A* image/.dockerignore
<https://github.com/jpillora/docker-dnsmasq/pull/40/files#diff-92a5028a1a3b1668c1fc40fce1f3fdc726ce6f66aa9f12ad938ac24c87297a13>
(2)
- *A* image/Dockerfile
<https://github.com/jpillora/docker-dnsmasq/pull/40/files#diff-74f4ca3519b9c2ddaa3a33d2ec8a039470fc6e6097e6c10e0eb0e18cb2af64e4>
(28)
- *A* image/rootfs/etc/default/dnsmasq
<https://github.com/jpillora/docker-dnsmasq/pull/40/files#diff-8b18fa4e7763dccf3b59780455f618059aba06020989dc243c1ac63cab74e552>
(2)
- *R* image/rootfs/etc/dnsmasq.conf
<https://github.com/jpillora/docker-dnsmasq/pull/40/files#diff-a0725ea027d94616d86fbd80a4167d5496bda480cffacd68f163b56667178116>
(0)
Patch Links:
- https://github.com/jpillora/docker-dnsmasq/pull/40.patch
- https://github.com/jpillora/docker-dnsmasq/pull/40.diff
—
Reply to this email directly, view it on GitHub
<#40>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAE2X474SF7WMD56EISRBNT4I7EMZAVCNFSM6AAAAACTCZMW5GVHI2DSMVQWIX3LMV43ASLTON2WKOZTHA3DEMZVGU4DGOI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't know if this project is still active, but here goes my changes in a nutshell:
maintainerLABEL Dockerfile instruction into the correct/supported/expected syntax (https://docs.docker.com/reference/dockerfile/#maintainer-deprecated)image, andimage/rootfscontains all the files that should be copied into the container image we are buildingNo CI/CD stuff as of yet. This is just to modernize/modularize/standardize things.