bump go1.18, lint and http client #92
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glaslos
commented
Aug 18, 2024
glaslos
commented
- Bump minimum Go version to 1.18
- Addressing various linter warnings
- Using an initiated HTTP client with a default timeout
jpillora
reviewed
Aug 19, 2024
|
|
||
| //http client where we change the timeout | ||
| s.client = &http.Client{ | ||
| Timeout: time.Second * 10, |
Author
There was a problem hiding this comment.
http.Get uses the default client which has no timeout
jpillora
reviewed
Aug 19, 2024
| mp.descriptorsReleased = make(chan bool) | ||
| //read all master process signals | ||
| signals := make(chan os.Signal) | ||
| signals := make(chan os.Signal, 1) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.