Warning when submission parsing failed #2318
Conversation
Kr0nox
added
enhancement
|
| // send a warning the first time the report is opened with the failed submissions | ||
| const failedSubmissionNames = json.failed_submission_names as string[] | ||
| if (failedSubmissionNames.length > 0) { | ||
| const hasSendWarning = sessionStorage.getItem('failedSubmissionWarning') |
There was a problem hiding this comment.
What happens if I load another report with failed parsing ? Or is this not possible anymore ? Does this reset the session store ?
There was a problem hiding this comment.
Yes that could be an issue.
We could always reset the token when opening the landing page, although that might not cover some edge cases.
Alternativly we could store some (nearly) unique identifier for a report/failed submission list to store what the last report we sent the warning for is.
What do you think is the best way? @jplag/maintainer
There was a problem hiding this comment.
Do I understand it correctly that this scenario would always arise when opening more than one report at the same time, where at least one submission failed? Then we definitely need a solution here. I'm not sure what the drawbacks of both approaches here are, so hard to judge from my end.
There was a problem hiding this comment.
We should discuss in the next meeting(s) whether this is a one-time warning needed and what is the best way to inform users that there have been problems without making the warning a) too easy to overlook and b) too annoying. I would guess there is still more to experiment with than we can achieve until the next release. This feature is too important to rush a change that makes everything worse.
When the report contains failed submissions, the browser displays an alert to the user informing them about it
Also adds the names of failed submissions to the information view