Skip to content

Warning when submission parsing failed #2318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 23, 2025

Conversation

Kr0nox
Copy link
Member

@Kr0nox Kr0nox commented Apr 20, 2025

When the report contains failed submissions, it displays a visible message in the top of the overview

Also adds the names of failed submissions to the information view

grafik
grafik
grafik
grafik

@Kr0nox Kr0nox added enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies labels Apr 20, 2025
@Kr0nox Kr0nox requested a review from a team April 20, 2025 06:05
@Kr0nox Kr0nox added this to the 6.1.0 milestone Apr 20, 2025
@tsaglam tsaglam requested a review from a team April 22, 2025 11:25
@robinmaisch robinmaisch removed this from the 6.1.0 milestone Apr 24, 2025
Copy link
Member

@tsaglam tsaglam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I proposed a follow-up idea in #2382. But I would do that in a separate PR.

Copy link
Member

@dfuchss dfuchss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope that I don't oversee a thing here :D

Copy link
Member

@robinmaisch robinmaisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some comment, but I like the presentation of the warning.

@dfuchss

This comment was marked as off-topic.

@dfuchss dfuchss requested a review from Copilot May 19, 2025 12:52
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds support for displaying a warning and listing submissions that failed to parse in both the overview header and the information panel.

  • Introduces failedSubmissionNames in the data model and factory
  • Shows a tooltip in OverviewView.vue with a count and truncated list of failures
  • Adds a “Failed Submissions” field in InformationView.vue to list all failed names

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
report-viewer/tests/unit/model/factories/OverviewFactory.test.ts Updated test to include _failedSubmissionNames: [] by default
report-viewer/src/model/factories/OverviewFactory.ts Parses json.failed_submission_names and passes it into Overview
report-viewer/src/model/Overview.ts Added private _failedSubmissionNames field and a getter
report-viewer/src/views/OverviewView.vue Renders warning tooltip with count and truncated names list
report-viewer/src/views/InformationView.vue Added TextInformation entry to show all failed submission names
Comments suppressed due to low confidence (1)

report-viewer/tests/unit/model/factories/OverviewFactory.test.ts:157

  • Consider adding a test case with a non-empty failedSubmissionNames array to verify correct handling and rendering.
_failedSubmissionNames: []

Copy link

@Kr0nox Kr0nox requested review from robinmaisch and dfuchss May 22, 2025 11:20
@tsaglam tsaglam merged commit 6a2d1cd into develop May 23, 2025
53 checks passed
@tsaglam tsaglam deleted the report-viewer/failed-submissions-warning branch May 23, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants