Warning when submission parsing failed #2318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kr0nox
added
enhancement
dfuchss
reviewed
Apr 20, 2025
dfuchss
requested changes
May 19, 2025
robinmaisch
requested changes
May 19, 2025
This comment was marked as off-topic.
This comment was marked as off-topic.
There was a problem hiding this comment.
Pull Request Overview
Adds support for displaying a warning and listing submissions that failed to parse in both the overview header and the information panel.
- Introduces
failedSubmissionNamesin the data model and factory - Shows a tooltip in
OverviewView.vuewith a count and truncated list of failures - Adds a “Failed Submissions” field in
InformationView.vueto list all failed names
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| report-viewer/tests/unit/model/factories/OverviewFactory.test.ts | Updated test to include _failedSubmissionNames: [] by default |
| report-viewer/src/model/factories/OverviewFactory.ts | Parses json.failed_submission_names and passes it into Overview |
| report-viewer/src/model/Overview.ts | Added private _failedSubmissionNames field and a getter |
| report-viewer/src/views/OverviewView.vue | Renders warning tooltip with count and truncated names list |
| report-viewer/src/views/InformationView.vue | Added TextInformation entry to show all failed submission names |
Comments suppressed due to low confidence (1)
report-viewer/tests/unit/model/factories/OverviewFactory.test.ts:157
- Consider adding a test case with a non-empty
failedSubmissionNamesarray to verify correct handling and rendering.
_failedSubmissionNames: []
|
dfuchss
approved these changes
May 23, 2025
robinmaisch
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the report contains failed submissions, it displays a visible message in the top of the overview
Also adds the names of failed submissions to the information view