-
Notifications
You must be signed in to change notification settings - Fork 351
Warning when submission parsing failed #2318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I proposed a follow-up idea in #2382. But I would do that in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hope that I don't oversee a thing here :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some comment, but I like the presentation of the warning.
This comment was marked as off-topic.
This comment was marked as off-topic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds support for displaying a warning and listing submissions that failed to parse in both the overview header and the information panel.
- Introduces
failedSubmissionNames
in the data model and factory - Shows a tooltip in
OverviewView.vue
with a count and truncated list of failures - Adds a “Failed Submissions” field in
InformationView.vue
to list all failed names
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
report-viewer/tests/unit/model/factories/OverviewFactory.test.ts | Updated test to include _failedSubmissionNames: [] by default |
report-viewer/src/model/factories/OverviewFactory.ts | Parses json.failed_submission_names and passes it into Overview |
report-viewer/src/model/Overview.ts | Added private _failedSubmissionNames field and a getter |
report-viewer/src/views/OverviewView.vue | Renders warning tooltip with count and truncated names list |
report-viewer/src/views/InformationView.vue | Added TextInformation entry to show all failed submission names |
Comments suppressed due to low confidence (1)
report-viewer/tests/unit/model/factories/OverviewFactory.test.ts:157
- Consider adding a test case with a non-empty
failedSubmissionNames
array to verify correct handling and rendering.
_failedSubmissionNames: []
|
When the report contains failed submissions, it displays a visible message in the top of the overview
Also adds the names of failed submissions to the information view