Java token position tests - Continue to Loop end#2917
Merged
Conversation
robinmaisch
reviewed
May 6, 2026
| long start = positions.getStartPosition(ast, node); | ||
| // This is odd, but also done like this in Java 1.7 | ||
| addToken(JavaTokenType.J_GENERIC, start, 1, new CodeSemantics()); | ||
| // This is odd, but also done like this in Javagg 1.7 |
|
robinmaisch
force-pushed
the
feature/tokenPositionTests2
branch
from
580da25 to
57f6ce8
Compare
|
robinmaisch
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contains tests for token positions for the java token types continue to loop_end.
This PR also adjusts some token lengths. Since it does not change the token list, I think it's fine to do this without a separate PR