Conversation
jplatte
force-pushed
the
slab
branch
3 times, most recently
from
3860300 to
73ccb62
Compare
jplatte
commented
Jul 27, 2024
Owner
Author
jplatte
left a comment
jplatte
left a comment
There was a problem hiding this comment.
Note to self: drop waker when next / next_ref future is aborted (dropped), not just when subscriber is dropped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The second commit is the interesting bit, where we drop wakers for subscribers that are no longer waiting for updates due to being dropped... However, we probably also need to catch the case where the subscriber still exists / at least detect
waker_keybeingSomewhen it is being set.Note to self: Add tests for both subscribers being dropped early, and subscriber awaiting being timed out.
Closes #42.