Python3 conversion patch #38
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting. I should have seen this before I did the same thing. To compare, you can see my code here: https://github.com/cornwarecjp/fritzcap (Python3 port is split over multiple commits). On quick inspection of your changes, it seems you've been more thorough than I was, maybe because I haven't tested every feature. OTOH I may have spotted more sensible fixes, e.g. the conversion to int in g711_decoder.py. |
Owner
|
Right now I have not been using Fritz!Box for VoIP since the end of 2022, as we moved and as a result had to put all VoIP stuff on a Siemens GigaSet device. It looks like towards the end of the year I am going to do use VoIP on a different Fritz!Box location, which hopefully means I can devote some time to fritzcap again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello my friend. I hope you are doing well.
I successfully converted the code to work with Python 3.
I have been testing it and I don't see any issue.
Feel free to merge it.