Draft
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
4a984a1 to
932e778
Compare
1211fe9 to
e3496f0
Compare
9c5cf7d to
23c4495
Compare
0004ef5 to
482645e
Compare
edf5bd8 to
359a45f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR shows the diff of what's been tried with Figma code connect for Salt DS Figma library. This is an "off-the-book" effort to enhance dev mode experience before we have a full roadmap around supporting it.
#4810
Figma code connect docs -
https://github.com/figma/code-connect/blob/main/docs/react.md
packages/core/figma-srcLearnings
Most of text / label in our Figma components is controlled via 2 props (one boolean & one string), therefore code connect will generate 2 separate prop mapping (one
figma.boolean&figma.string). The correct way to map them is usingvalueMappingobject, e.g. below. See more on Figma doc.When using
npx figma connect, our Figma library is too large with below errorIn order to get node ids on a page in batch, can use REST API get file nodes, e.g.,
https://api.figma.com/v1/files/7Fh5JbUUM84pYwLt9tpJh2/nodes?ids=7992-77669&depth=2(note thedepthto keep it small), then run some scripts on thecomponentSetswith something like belowScripts
For icons update from - https://github.com/figma/code-connect/blob/main/cli/scripts/import-icons.ts