refactor button styles implementation to more maintainable approach w…#4698
Draft
refactor button styles implementation to more maintainable approach w…#4698
Conversation
🦋 Changeset detectedLatest commit: a9ed8a9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mark-tate
force-pushed
the
refactor-button-styles
branch
from
c67d44a to
94cefa7
Compare
Contributor
|
before i forget, one of the reasons this was needed, was to enable cross component override (e.g. Icon). More testing is needed to confirm whether 1 type of variable is enough, and/or alternative approach |
joshwooding
force-pushed
the
refactor-button-styles
branch
from
94cefa7 to
221ed16
Compare
…ith simpler naming
joshwooding
force-pushed
the
refactor-button-styles
branch
from
15acf85 to
a9ed8a9
Compare
libertymayc
reviewed
Apr 10, 2025
|
|
||
| Refactor internal implementation of button styles | ||
|
|
||
| - this is a non-breaking refactor of how we organise the styles within the CSS file. |
Contributor
There was a problem hiding this comment.
checking, is this definitely considered non breaking/..only a patch? I personally have used a lot of --saltComponent tokens myself which would have to be changed by this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ith simpler naming