Skip to content

refactor: remove Unexpected any in 2 locations #4913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: remove Unexpected any in 2 locations #4913

wants to merge 1 commit into from

Conversation

hamirmahal
Copy link
Contributor

Fixes #4912

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 30, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 82caeb2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Mar 30, 2025

@hamirmahal is attempting to deploy a commit to the FED Team Team on Vercel.

A member of the Team first needs to authorize it.

hamirmahal
hamirmahal commented Mar 30, 2025
View reviewed changes
packages/ag-grid-theme/src/examples/ProvidedCellEditors.tsx
@@ -24,7 +24,7 @@ const dateString = {
string
>,
) => (params.value == null ? "" : params.value),
dataTypeMatcher: (value: any) =>
dataTypeMatcher: (value: string) =>
typeof value === "string" && !!value.match("\\d{2}/\\d{2}/\\d{4}"),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
typeof value === "string" && !!value.match("\\d{2}/\\d{2}/\\d{4}"),
!!value.match("\\d{2}/\\d{2}/\\d{4}"),

I thought about removing typeof value === "string" after changing the type of value to string, but that could cause runtime errors for consumers doing unsafe things like dataTypeMatcher(input as string).

origami-z
origami-z reviewed Mar 30, 2025
View reviewed changes
Copy link
Contributor

@origami-z origami-z left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change! Can you also check files in site/src/examples/ag-grid-theme, which is the source code for examples on Salt website.

CLA confirmed before.

@origami-z origami-z added CLA: Received CLA has been received community For issues that have been raised by folks outside the core Salt team labels Mar 30, 2025
@hamirmahal hamirmahal force-pushed the refactor/remove-2-unexpected-anys branch from c0bb2cf to 19d8a94 Compare March 30, 2025 22:20
@hamirmahal
Copy link
Contributor Author

Thanks! And sure.

@origami-z origami-z force-pushed the refactor/remove-2-unexpected-anys branch from 19d8a94 to 94b3c94 Compare March 31, 2025 10:31
@origami-z origami-z force-pushed the refactor/remove-2-unexpected-anys branch from 94b3c94 to 6ff2fdc Compare March 31, 2025 13:48
@origami-z
Copy link
Contributor

Need @joshwooding help on authorize Vercel

@vercel Vercel
Copy link

vercel bot commented Apr 2, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2025 8:53am

@hamirmahal hamirmahal force-pushed the refactor/remove-2-unexpected-anys branch from 6ff2fdc to 82caeb2 Compare April 2, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@origami-z origami-z origami-z approved these changes

@Fercas123 Fercas123 Fercas123 approved these changes

@yunjungyeh yunjungyeh yunjungyeh approved these changes

Assignees
No one assigned
Labels
CLA: Received CLA has been received community For issues that have been raised by folks outside the core Salt team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test / lint (push) Successful in 1m flags Unexpected any. in packages/ag-grid-theme/src/examples/
4 participants
@hamirmahal @origami-z @Fercas123 @yunjungyeh