Skip to content

[wip] Table component #5003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

[wip] Table component #5003

wants to merge 4 commits into from

Conversation

libertymayc
Copy link
Contributor

No description provided.

@libertymayc
table
c4c7fb7 
table
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 15, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 51efa4c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Apr 15, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ❌ Failed (Inspect) Apr 15, 2025 7:20pm

libertymayc
libertymayc commented Apr 15, 2025
View reviewed changes
packages/lab/src/table/Table.css

.saltTable-tbody .saltTable-tr:hover,
table.saltTable tbody tr:hover {
background: var(--saltTable-tr-background-hover, var(--salt-selectable-background-hover));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would hover styles be desired? @origami-z

origami-z
origami-z reviewed Apr 17, 2025
View reviewed changes
packages/lab/src/table/Table.tsx
variant?: "primary" | "secondary";
};
export type TableProps = ComponentPropsWithoutRef<"table"> & {
variant?: "primary" | "secondary";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zebra is also available :)

origami-z
origami-z reviewed Apr 17, 2025
View reviewed changes
packages/lab/src/table/Table.tsx
import { useWindow } from "@salt-ds/window";
import { clsx } from "clsx";
import { type ComponentPropsWithoutRef, forwardRef } from "react";
import "ag-grid-community/styles/ag-grid.css";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ag grid not needed here i guess

origami-z
origami-z reviewed Apr 17, 2025
View reviewed changes
Copy link
Contributor

@origami-z origami-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On top of design variant (primary/secondary/zebra), is there anything common could be beneficial? e.g., column width (fixed vs auto), sticky header, wrapping vs not, etc.? could brainstorm some first before implementing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@origami-z origami-z origami-z left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@libertymayc @origami-z