Skip to content

[Test] Corner radius support for ag grid theme #5059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
origami-z wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[Test] Corner radius support for ag grid theme #5059

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/ag-theme-rounded-corner.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@salt-ds/ag-grid-theme": minor
---

Added corner radius support for `.editable-cell` and floating filter when used in brand theme.
5 changes: 1 addition & 4 deletions packages/ag-grid-theme/css/parts/ag-body.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,6 @@
.ag-theme-salt-compact-light .ag-ltr .ag-cell-inline-editing,
.ag-theme-salt-compact-dark .ag-ltr .ag-cell-inline-editing {
padding: 0;
/* When styling option corner='rounded', we don't want this to be flipped between rounded and not between editing and normal state */
border-radius: 0;
}

.ag-theme-salt-light .ag-cell-inline-editing.editable-cell input[class^="ag-"],
Expand All @@ -86,6 +84,7 @@
.ag-theme-salt-compact-dark .editable-numeric-cell {
outline: var(--salt-size-border) var(--salt-container-borderStyle) var(--salt-editable-borderColor);
outline-offset: -1px;
border-radius: var(--salt-palette-corner-weak);
}

.ag-theme-salt-light .ag-cell.numeric-cell,
Expand Down Expand Up @@ -213,7 +212,6 @@
.ag-theme-salt-compact-light .ag-select .ag-picker-field-wrapper,
.ag-theme-salt-compact-dark .ag-select .ag-picker-field-wrapper {
border: var(--salt-size-border) var(--salt-separable-borderStyle) var(--salt-editable-borderColor);
border-radius: 0;
}

.ag-theme-salt-light .ag-ltr .editable-cell .ag-select .ag-picker-field-wrapper,
Expand All @@ -225,7 +223,6 @@
.ag-theme-salt-compact-dark .ag-ltr .editable-cell .ag-select .ag-picker-field-wrapper,
.ag-theme-salt-compact-dark .ag-ltr .editable-cell .ag-rich-select .ag-picker-field-wrapper {
padding: 0 var(--salt-spacing-100);
border-radius: 0;
}

.ag-theme-salt-light .ag-ltr .editable-cell .ag-select .ag-icon-small-down::before,
Expand Down
2 changes: 1 addition & 1 deletion packages/ag-grid-theme/css/parts/ag-checkbox.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
.ag-theme-salt-dark .ag-checkbox-input-wrapper,
.ag-theme-salt-compact-light .ag-checkbox-input-wrapper,
.ag-theme-salt-compact-dark .ag-checkbox-input-wrapper {
/* border-radius doesn't work given border is part of the font glyph */
/* border-radius doesn't work given border is part of the font glyph, v33 new theme approach will support this. */
height: var(--salt-size-selectable);
width: var(--salt-size-selectable);
font-size: var(--salt-size-selectable);
Expand Down
7 changes: 7 additions & 0 deletions packages/ag-grid-theme/css/parts/ag-header.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,3 +369,10 @@
margin-inline-start: var(--salt-spacing-100);
margin-inline-end: 0;
}

.ag-theme-salt-light .ag-header-cell.ag-floating-filter,
.ag-theme-salt-dark .ag-header-cell.ag-floating-filter,
.ag-theme-salt-compact-light .ag-header-cell.ag-floating-filter,
.ag-theme-salt-compact-dark .ag-header-cell.ag-floating-filter {
border-radius: var(--salt-palette-corner-weak);
}
Loading