AriaAnnouncer improvements, previously delay was used to queue an…
#5597
Conversation
…nouncements, but it could create overlapping announcements. We have deprecated `delay`, although it is still supported. Instead, we have added a new options API. - `duration`: provides a sequential delay between announcements, ensuring they do not overlap. - `ariaLive` determines the importance and urgency of the announcement.
🦋 Changeset detectedLatest commit: 4f317ba The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
/release-pr |
|
🫰✨ Thanks @mark-tate! Your snapshot has been published to npm. Test the snapshot by updating your yarn add @salt-ds/[email protected] |
|
Hi, I tested the snapshot @salt-ds/[email protected] with our Cypress component tests. The tests fail immediately with: Should the snapshot be exporting prebuilt CSS instead of raw src for tests, or should we add custom Cypress config to stub CSS imports? Thanks! |
this snapshot is to review the audio/behaviour of the aria-announcer, what are you trying to test with this snapshot ? You may have version issues, you would need to ensure the other Salt packages used with the snapshot are from the same version. Also you could compare with our cypress.config.ts |
|
@mark-tate, Just wanted to add while we can and should still support Delay/Duration I do not believe we should apply values to either of these by default. If using polite (which should set by default), I would also highly recommend adding ~300ms to debounce, like for the carousel. Ideally, in most cases, we should allow the screen reader to handle any queue/interruptions of messages. We could also add information to the docs to indicate that it is accessibility best practice to avoid, where possible, creating situations where multiple aria live messages are added in rapid succession. |
…nouncements, but it could create overlapping announcements. We have deprecated
delay, although it is still supported. Instead, we have added a new options API.duration: provides a sequential delay between announcements, ensuring they do not overlap.ariaLivedetermines the importance and urgency of the announcement.