Skip to content

cleanup some biome warnings #5674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mark-tate wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

cleanup some biome warnings #5674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/embla-carousel/src/Carousel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ export const Carousel = forwardRef<HTMLElement, CarouselProps>(
getEmblaApi?.(emblaApi);
}
return undefined;
}, [emblaApi]);
}, [emblaApi, getEmblaApi]);

const [ariaVariant, setAriaVariant] =
useState<CarouselAriaVariant>("group");
Expand Down
2 changes: 1 addition & 1 deletion packages/embla-carousel/src/CarouselAutoplayIndicator.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ export const CarouselAutoplayIndicator = forwardRef<
animationFrameId.current = null;
}
};
}, [circumference, duration, slideIndex, isPlaying, isPaused]);
}, [circumference, duration, isPlaying, isPaused]);

return (
<div
Expand Down
1 change: 1 addition & 0 deletions packages/embla-carousel/src/CarouselCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ export const CarouselCard = forwardRef<HTMLDivElement, CarouselCardProps>(
const { ariaVariant } = useCarouselContext();

return (
// biome-ignore lint/a11y/useAriaPropsSupportedByRole: role is set dynamically by variable
<div
aria-roledescription="slide"
className={clsx([withBaseName(), className])}
Expand Down
4 changes: 2 additions & 2 deletions packages/embla-carousel/src/CarouselSlides.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ export const CarouselSlides = forwardRef<HTMLDivElement, CarouselSlidesProps>(
emblaApi.off("scroll", scrollCallback);
emblaApi.off("pointerDown", pointerDownCallback);
};
}, [emblaApi]);
}, [emblaApi, setAnnouncementState]);

useLayoutEffect(() => {
if (focusSlideIndex >= 0) {
Expand All @@ -118,7 +118,7 @@ export const CarouselSlides = forwardRef<HTMLDivElement, CarouselSlidesProps>(
if (disableSlideAnnouncements === false) {
setAnnouncementState(undefined);
}
}, [disableSlideAnnouncements]);
}, [disableSlideAnnouncements, setAnnouncementState]);

useEffect(() => {
if (
Expand Down
2 changes: 1 addition & 1 deletion packages/embla-carousel/src/CarouselTabList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ export const CarouselTabList = forwardRef<HTMLDivElement, CarouselTabListProps>(

return (
<CarouselTabRenderer
key={`carouselTab-${scrollSnapIndex}}`}
key={`carouselTab-${slideNodes?.[scrollSnapIndex].id}}`}
ref={(element: HTMLButtonElement) => {
buttonRefs.current[scrollSnapIndex] = element;
}}
Expand Down
Loading