Skip to content

Fix selectable hover tokens' contrast issues #5727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
joshwooding wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix selectable hover tokens' contrast issues #5727

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47d77ba
Fix selectable hover tokens' contrast issues
joshwooding Oct 27, 2025
da81f3b
Align to actionable
joshwooding Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/dull-seas-float.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@salt-ds/theme": patch
---

Updated `--salt-selectable-borderColor-hover` and `--salt-selectable-foreground-hover` to address color contrast issues.
4 changes: 2 additions & 2 deletions packages/theme/css/next/characteristics/selectable.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
.salt-theme.salt-theme-next {
--salt-selectable-borderColor: var(--salt-palette-neutral);
--salt-selectable-borderColor-hover: var(--salt-palette-accent-weak);
--salt-selectable-borderColor-hover: var(--salt-palette-accent);
--salt-selectable-borderColor-selected: var(--salt-palette-accent);
--salt-selectable-borderColor-selectedDisabled: var(--salt-palette-accent-disabled);
--salt-selectable-borderColor-disabled: var(--salt-palette-neutral-disabled);
--salt-selectable-borderColor-readonly: var(--salt-palette-neutral);

--salt-selectable-foreground: var(--salt-palette-neutral-strong);
--salt-selectable-foreground-disabled: var(--salt-palette-neutral-strong-disabled);
--salt-selectable-foreground-hover: var(--salt-palette-accent-weak);
--salt-selectable-foreground-hover: var(--salt-palette-accent);
--salt-selectable-foreground-selected: var(--salt-palette-accent);
--salt-selectable-foreground-selectedDisabled: var(--salt-palette-accent-disabled);
--salt-selectable-background: var(--salt-palette-alpha-none);
Expand Down
Loading