Skip to content

Conversation

@amritadesmet
Copy link
Contributor

  • Update images to reflect new tokens
  • Remove radii on all images
  • Update 'image' to 'diagram' mdx syntax

@changeset-bot
Copy link

changeset-bot bot commented Dec 2, 2025

⚠️ No Changeset found

Latest commit: a35b0c8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 2, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
saltdesignsystem Ready Ready Preview Comment Dec 3, 2025 11:17am

@joshwooding
Copy link
Contributor

Can we check the dark mode on the site, even though the images look to be transparent it's not really working on the site for me.

@amritadesmet
Copy link
Contributor Author

Yeah it's not working for me either @joshwooding, I'm checking with Honey right now if I missed something or need to add back the dark src even though some images don't require a dark mode version as that content wouldn't change with mode.

@amritadesmet
Copy link
Contributor Author

Fixed all images. Pattern fills img is purposely light mode only due to pattern fills always being black in all use cases and on the dark mode background, it won't be accessible.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping the white background on this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a look. Yes, pattern fills img is purposely light mode only due to pattern fills always being black in all use cases and on the dark mode background, it won't be accessible.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the dataviz-tooltip.png does it apply here as well? Saw your previous note about the pattern I assumed that only applied to dataviz-pattern-fills*

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just putting my opinion here, I actually think the color doesn't matter here. We're documenting the patterns not really the color, that's handled elsewhere. I know the bright white background in dark mode is generally undesirable

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also technically the line patterns would only be in a categorical color right? and we show them in content colors

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Valid point, I'll change the pattern fill image so it works in dark mode when I address this. I made the line patterns black because the cat color re-order will require maintenance to update the image again in the future.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tooltip image also needs to be looked at please

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, had a meeting with @honey-chang to discuss the necessary changes. Will be updated.

Co-authored-by: David Oyedeji <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants