-
Notifications
You must be signed in to change notification settings - Fork 114
Update data viz images #5862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update data viz images #5862
Conversation
amritadesmet
commented
Dec 2, 2025
- Update images to reflect new tokens
- Remove radii on all images
- Update 'image' to 'diagram' mdx syntax
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Can we check the dark mode on the site, even though the images look to be transparent it's not really working on the site for me. |
|
Yeah it's not working for me either @joshwooding, I'm checking with Honey right now if I missed something or need to add back the dark src even though some images don't require a dark mode version as that content wouldn't change with mode. |
|
Fixed all images. Pattern fills img is purposely light mode only due to pattern fills always being black in all use cases and on the dark mode background, it won't be accessible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keeping the white background on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking a look. Yes, pattern fills img is purposely light mode only due to pattern fills always being black in all use cases and on the dark mode background, it won't be accessible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the dataviz-tooltip.png does it apply here as well? Saw your previous note about the pattern I assumed that only applied to dataviz-pattern-fills*
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just putting my opinion here, I actually think the color doesn't matter here. We're documenting the patterns not really the color, that's handled elsewhere. I know the bright white background in dark mode is generally undesirable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also technically the line patterns would only be in a categorical color right? and we show them in content colors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Valid point, I'll change the pattern fill image so it works in dark mode when I address this. I made the line patterns black because the cat color re-order will require maintenance to update the image again in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tooltip image also needs to be looked at please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, had a meeting with @honey-chang to discuss the necessary changes. Will be updated.
Co-authored-by: David Oyedeji <[email protected]>
Co-authored-by: David Oyedeji <[email protected]>
db65bef to
617f1a8
Compare
Co-authored-by: David Oyedeji <[email protected]>