Add read-only Switch

.changeset/two-clouds-hug.md

@@ -0,0 +1,11 @@
+---
+"@salt-ds/core": patch
+---
+
+Added support for read-only `Switch` via `readOnly` prop.
+
+Example usage:
+
+```jsx
+<Switch readOnly label="Read only" />
+```

packages/core/src/__tests__/__e2e__/switch/Switch.cy.tsx

@@ -175,4 +175,21 @@ describe("GIVEN a Switch", () => {
     cy.findByRole("switch").should("be.focused");
     cy.findByRole("switch").should("be.checked");
   });
+
+  describe("WHEN readOnly is true", () => {
+    it("THEN should not toggle if clicked", () => {
+      cy.mount(<Switch readOnly />);
+      cy.findByRole("switch").should("not.be.checked");
+      cy.findByRole("switch").realClick();
+      cy.findByRole("switch").should("not.be.checked");
+    });
+
+    it("THEN should not toggle when pressing the Space key", () => {
+      cy.mount(<Switch readOnly />);
+      cy.findByRole("switch").should("not.be.checked");
+      cy.realPress("Tab");
+      cy.realPress("Space");
+      cy.findByRole("switch").should("not.be.checked");
+    });
+  });
 });

packages/core/src/switch/Switch.css

@@ -110,6 +110,32 @@
   width: calc((var(--salt-size-selectable) + var(--salt-spacing-25) + var(--salt-size-fixed-100)) * 2);
 }
 
+.saltSwitch-readOnly {
+  cursor: var(--salt-cursor-text);
+}
+
+.saltSwitch-readOnly .saltSwitch-track,
+.saltSwitch-readOnly:hover .saltSwitch-track {
+  border-color: var(--salt-selectable-borderColor-readonly);
+  color: var(--salt-content-primary-foreground);
+}
+
+.saltSwitch-readOnly:hover .saltSwitch-thumb {
+  border-color: var(--salt-selectable-borderColor-readonly);
+}
+
+.saltSwitch-readOnly .saltSwitch-thumb,
+.saltSwitch-readOnly.saltSwitch-checked .saltSwitch-thumb {
+  background: var(--salt-container-primary-background);
+  border: var(--salt-size-fixed-100) var(--salt-borderStyle-dashed) var(--salt-selectable-borderColor-readonly);
+}
+
+.saltSwitch-readOnly .saltSwitch-input:focus-visible + .saltSwitch-track,
+.saltSwitch-readOnly .saltSwitch-input:focus-visible + .saltSwitch-track .saltSwitch-thumb {
+  border-color: var(--salt-selectable-borderColor-readonly);
+  color: var(--salt-content-primary-foreground);
+}
+
 @media (prefers-reduced-motion) {
   .saltSwitch-input:focus-visible + .saltSwitch-track .saltSwitch-thumb,
   .saltSwitch:hover .saltSwitch-thumb {
@@ -121,6 +147,10 @@
   border: 0;
 }
 
+.salt-density-high .saltSwitch-readOnly .saltSwitch-thumb {
+  border: var(--salt-size-fixed-100) var(--salt-borderStyle-dashed) var(--salt-selectable-borderColor-readonly);
+}
+
 /* Styles applied when switch is inside a form field with label left or right, ensuring alignment with base / input height */
 .saltFormField-labelRight .saltSwitch,
 .saltFormField-labelLeft .saltSwitch {

packages/core/src/switch/Switch.tsx

@@ -1,4 +1,4 @@
-import { CheckmarkSolidIcon } from "@salt-ds/icons";
+import { CheckmarkIcon, CheckmarkSolidIcon } from "@salt-ds/icons";
 import { useComponentCssInjection } from "@salt-ds/styles";
 import { useWindow } from "@salt-ds/window";
 import { clsx } from "clsx";
@@ -61,6 +61,10 @@ export interface SwitchProps
    * The value of the switch.
    */
   value?: string;
+  /**
+   * If `true`, the switch will be read-only.
+   */
+  readOnly?: boolean;
 }
 
 const withBaseName = makePrefixer("saltSwitch");
@@ -79,6 +83,7 @@ export const Switch = forwardRef<HTMLLabelElement, SwitchProps>(
       onChange,
       onFocus,
       value,
+      readOnly: readOnlyProp,
       ...rest
     } = props;
 
@@ -104,14 +109,18 @@ export const Switch = forwardRef<HTMLLabelElement, SwitchProps>(
       state: "checked",
     });
 
-    const { a11yProps: formFieldA11yProps, disabled: formFieldDisabled } =
-      useFormFieldProps();
+    const {
+      a11yProps: formFieldA11yProps,
+      disabled: formFieldDisabled,
+      readOnly: formFieldReadOnly,
+    } = useFormFieldProps();
 
     const disabled = formFieldDisabled || disabledProp;
+    const readOnly = formFieldReadOnly || readOnlyProp;
 
     const handleChange: ChangeEventHandler<HTMLInputElement> = (event) => {
       // Workaround for https://github.com/facebook/react/issues/9023
-      if (event.nativeEvent.defaultPrevented) {
+      if (event.nativeEvent.defaultPrevented || readOnly) {
         return;
       }
 
@@ -128,13 +137,15 @@ export const Switch = forwardRef<HTMLLabelElement, SwitchProps>(
           {
             [withBaseName("disabled")]: disabled,
             [withBaseName("checked")]: checked,
+            [withBaseName("readOnly")]: readOnly,
           },
           className,
         )}
         ref={ref}
         {...rest}
       >
         <input
+          aria-readonly={readOnly || undefined}
           aria-describedby={clsx(
             formFieldA11yProps?.["aria-describedby"],
             inputDescribedBy,
@@ -149,6 +160,7 @@ export const Switch = forwardRef<HTMLLabelElement, SwitchProps>(
           className={clsx(withBaseName("input"), inputClassName)}
           defaultChecked={defaultChecked}
           disabled={disabled}
+          readOnly={readOnly}
           onBlur={onBlur}
           onChange={handleChange}
           onFocus={onFocus}
@@ -159,12 +171,15 @@ export const Switch = forwardRef<HTMLLabelElement, SwitchProps>(
         />
         <span className={withBaseName("track")}>
           <span className={withBaseName("thumb")}>
-            {checked && (
+            {checked && !readOnly && (
               <CheckmarkSolidIcon
                 aria-hidden
                 className={withBaseName("icon")}
               />
             )}
+            {checked && readOnly && (
+              <CheckmarkIcon aria-hidden className={withBaseName("icon")} />
+            )}
           </span>
         </span>
         {label && <span className={withBaseName("label")}>{label}</span>}

packages/core/stories/switch/switch.qa.stories.tsx

@@ -18,7 +18,7 @@ export const AllExamplesGrid: StoryFn<
 > = (props) => {
   const { className } = props;
   return (
-    <QAContainer cols={4} {...props}>
+    <QAContainer cols={6} {...props}>
       <Switch className={className} label="Default" />
       <Switch className={className} checked label="Checked" />
       <Switch className={className} disabled label="Disabled" />
@@ -28,6 +28,13 @@ export const AllExamplesGrid: StoryFn<
         disabled
         label="Checked + Disabled"
       />
+      <Switch
+        className={className}
+        checked
+        readOnly
+        label="Checked + Readonly"
+      />
+      <Switch className={className} readOnly label="Readonly" />
     </QAContainer>
   );
 };

packages/core/stories/switch/switch.stories.tsx

@@ -70,3 +70,10 @@ export const WithFormField: StoryFn<typeof Switch> = (args) => {
     </StackLayout>
   );
 };
+
+export const Readonly: StoryFn<typeof Switch> = () => (
+  <StackLayout>
+    <Switch readOnly checked label="Read only + checked" />
+    <Switch readOnly label="Read only" />
+  </StackLayout>
+);

site/docs/components/switch/accessibility.mdx

@@ -8,6 +8,10 @@ data:
   $ref: ./#/data
 ---
 
+## Best Practice
+
+Ideally we shouln't use readOnly 
+
 ## Keyboard interactions
 
 <KeyboardControls>

site/docs/components/switch/examples.mdx

@@ -48,6 +48,16 @@ Use a disabled checked state for switches that have permissions, dependencies or
 
 <LivePreview componentName="switch" exampleName="DisabledChecked" />
 
+## Read-only
+
+A read-only switch allows the user to select and copy its text, but does not allow them to change its state. You can set a switch as read-only via the prop `readOnly`.
+
+### Best practices
+
+Unlike disabled switches, read-only switches are focusable and shown in the tab order when using a keyboard, allowing users to interact with its text. Use a read-only Switch when its text contains information that is valuable to the user.
+
+<LivePreview componentName="switch" exampleName="Readonly" />
+
 ## Left aligned label
 
 Use a form field if you need a left aligned label, avoid also having a switch label.

site/src/examples/switch/Readonly.tsx

@@ -0,0 +1,9 @@
+import { StackLayout, Switch } from "@salt-ds/core";
+import type { ReactElement } from "react";
+
+export const Readonly = (): ReactElement => (
+  <StackLayout>
+    <Switch readOnly checked label="Read only + checked" />
+    <Switch readOnly label="Read only" />
+  </StackLayout>
+);

site/src/examples/switch/index.ts

@@ -3,3 +3,4 @@ export * from "./DefaultChecked";
 export * from "./Disabled";
 export * from "./DisabledChecked";
 export * from "./LeftAlignedLabel";
+export * from "./Readonly";