Data grid header new code #5918
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Fixed indentation.
tycup
reviewed
Dec 19, 2025
| description: AG Grid Theme is a package that adds Salt theme styles to AG Grid. The package contains CSS files only, and works with AG Grid from version 28 upwards which has CSS variable support. The examples provided below utilize AG Grid version 32.2.2. | ||
| description: "Data Grid is an interactive table for efficiently displaying data, supporting advanced features such as frozen columns, editable cells, custom cell renderers and flexible selection capabilities for rows and columns." | ||
| sourceCodeUrl: "https://github.com/jpmorganchase/salt-ds/blob/main/packages/ag-grid-theme" | ||
| alsoKnownAs: ["AG Grid Theme] |
Contributor
There was a problem hiding this comment.
Suggested change
| alsoKnownAs: ["AG Grid Theme] | |
| alsoKnownAs: ["AG Grid Theme"] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added in the new code for component header with external dependency info tailored to Data grid -- but we'll still want to change the URL and page name to reflect that this component is known as Data grid, rather than AG Grid theme, going forward.