add baseline.css to normalize browser defaults (#6805)#6806
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: b4586a7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| /* Modern box-sizing — every element (and pseudo-element) uses | ||
| * border-box so widths / heights include padding and border. */ | ||
| *, | ||
| *::before, |
There was a problem hiding this comment.
All Salt component will still have to handle this
| margin-block: 0; | ||
| margin-inline: 0; | ||
| padding: 0; | ||
| padding-block: 0; | ||
| padding-inline: 0; |
There was a problem hiding this comment.
The shorthand CSS here isn't supported by our minimum browsers
| h4, | ||
| h5, | ||
| h6 { | ||
| font-size: inherit; |
|
|
||
| /* Form controls — inherit typography so bare inputs / buttons don't | ||
| * fall back to the browser's system font. */ | ||
| input, |
| color: inherit; | ||
| } | ||
|
|
||
| /* Bare `<button>` — strip UA chrome. Salt's `<Button>` component |
There was a problem hiding this comment.
I don't think we should care about this? It's more likely to break things than fix
| } | ||
|
|
||
| /* Fieldsets ship with a browser-default border that is almost | ||
| * never wanted. Padding is already zeroed above. */ |
There was a problem hiding this comment.
Feels like a level of opinionation we don't need to have?
|
|
||
| /* Collapse table borders by default so bare tables don't render | ||
| * with the browser's "double line" cell borders. */ | ||
| table { |
There was a problem hiding this comment.
We already have a table component
| /* Anchor color inherits from the surrounding text so unthemed | ||
| * `<a>` elements do not render as the browser's default bright | ||
| * blue. Salt's `<Link>` component still applies its own treatment. */ | ||
| a { |
There was a problem hiding this comment.
I also don't think we should do this either
2 participants
No description provided.