Fix empty read-only logic and align Dropdown validation precedence#6829
Open
joshwooding wants to merge 2 commits into
Open
Fix empty read-only logic and align Dropdown validation precedence#6829joshwooding wants to merge 2 commits into
joshwooding wants to merge 2 commits into
Conversation
joshwooding
commented
Jul 13, 2026
joshwooding
commented
Contributor
- Input: treat numeric 0 as a real value when read-only instead of showing the empty read-only marker
- PillInput: same read-only empty-value handling for consistency (internal)
- Dropdown: FormField validation status now takes precedence over the local validationStatus prop, matching the other form controls
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: dfa10f6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
joshwooding
force-pushed
the
fix/readonly-zero-and-dropdown-validation
branch
from
July 13, 2026 23:20
26d1004 to
df01d57
Compare
joshwooding
force-pushed
the
fix/readonly-zero-and-dropdown-validation
branch
from
July 15, 2026 09:45
df01d57 to
2fc4eec
Compare
joshwooding
changed the title
tycup
previously approved these changes
Jul 16, 2026
wemmyo
previously approved these changes
Jul 16, 2026
wemmyo
reviewed
Jul 16, 2026
joshwooding
added
the
chromatic
- Input: treat numeric 0 as a real value when read-only instead of showing the empty read-only marker - PillInput: same read-only empty-value handling for consistency (internal) - Dropdown: FormField validation status now takes precedence over the local validationStatus prop, matching the other form controls - Add e2e tests for Input zero value, Dropdown validation precedence, and ComboBox read-only marker
joshwooding
force-pushed
the
fix/readonly-zero-and-dropdown-validation
branch
from
July 16, 2026 14:16
2fc4eec to
864277c
Compare
github-actions
Bot
removed
the
chromatic
joshwooding
added
the
chromatic
github-actions
Bot
removed
the
chromatic
joshwooding
added
the
chromatic
joshwooding
force-pushed
the
fix/readonly-zero-and-dropdown-validation
branch
from
July 17, 2026 14:51
f79a044 to
dfa10f6
Compare
github-actions
Bot
removed
the
chromatic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.