Route Day.js operations through injected factory#6836
Open
joshwooding wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: e37d5f0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
joshwooding
force-pushed
the
fix-dayjs-adapter
branch
2 times, most recently
from
July 15, 2026 10:55
51c1364 to
c07e702
Compare
tycup
reviewed
Jul 15, 2026
joshwooding
force-pushed
the
fix-dayjs-adapter
branch
from
July 15, 2026 14:22
c07e702 to
e37d5f0
Compare
tycup
approved these changes
Jul 15, 2026
wemmyo
reviewed
Jul 16, 2026
wemmyo
reviewed
Jul 16, 2026
| } | ||
| if (timezone === "system") { | ||
| return defaultDayjs.tz.guess(); | ||
| return this.dayjs.tz?.guess?.() ?? defaultDayjs.tz.guess(); |
Contributor
There was a problem hiding this comment.
Is it worth having a separate function to guess system timezone?
Contributor
Author
There was a problem hiding this comment.
I don't think so? It's only used a few times
mark-tate
reviewed
Jul 16, 2026
| "@salt-ds/date-adapters": patch | ||
| --- | ||
|
|
||
| Fixed the Day.js adapter to consistently use an injected Day.js factory for timezone resolution, UTC/timezone date creation, `today`, and `now`. |
Contributor
There was a problem hiding this comment.
does this adequatelyexplain the additional props and any docs need updating ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.