-
Notifications
You must be signed in to change notification settings - Fork 251
Add discord rpc #605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add discord rpc #605
Conversation
jacksongoode
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is nice - thank you for contributing! but I'd like to do a proper re-review after the unrelated linting changes were resolved.
aae9446 to
d709f7b
Compare
The lsp defaults to 4 spaces for some reason without it
b5eacf2 to
e3fa164
Compare
|
I had a little skim over this PR! It's looking good so far! Also I think the taplo.toml shouldn't be included to the PR. |
|
Just a question, do we have to make it so that the user makes up their ID or are we able to say generate it for them so its more automatic? |
|
Link #186 to close |
closes #186
Add Discord Rich Presence (RPC) Support
This adds basic support for Discord Rich Presence to psst.
If you enable it and provide a valid Discord Application ID, the app will connect to your running Discord client and show the currently playing track in your profile.
Changes
discord_rpc.rsmodule underpsst-coreto manage the Discord RPC connection in a background thread.discord-presenceas a new dependency.discord_rpc_enable(bool)discord_rpc_app_id(string)PlaybackController:Behavior
Notes
discord-presence.Screenshots
Why
Because Discord status is cool
and now people can see what garbage music you're listening to in real time.