Skip to content

Use readable-stream 3#4

Open
realityking wants to merge 1 commit into
jpommerening:masterfrom
realityking:readablestream-3
Open

Use readable-stream 3#4
realityking wants to merge 1 commit into
jpommerening:masterfrom
realityking:readablestream-3

Conversation

@realityking

Copy link
Copy Markdown

This will require a new major release.

@jimmywarting

jimmywarting commented Sep 30, 2021

Copy link
Copy Markdown

i would have wished it used the builtin node version so you would always get the latest version... otherwise this can lag behind in new features such as not being able to use async iterator... readable-stream is already lagging behind and installs unnecessary dependencies

if you are gona make a breaking release, then also take the opportunity to use class extend instead of using the discuraged inherits fn

@orgads

orgads commented May 25, 2025

Copy link
Copy Markdown

Done in:

Also removed readable-stream dependency and replaced it with built-in stream. For modern node versions, I don't see any value with using readable-stream.

@KoderPex

KoderPex commented Jul 23, 2025

Copy link
Copy Markdown

Has some estimative of publishing this PR ?
This is one of dependencies of archiver-utils@2.1.0 || archiver-utils@3.0.4, which is dependency of exceljs@4.4.0.
All other dependencies of exceljs@4.4.0 are using readable-stream:3.6.2 version, only node-lazystream is using version 2.x.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants