Implement length rule for urls #147
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using
Url
structs directly in my forms to make working with them more convenient. With this patch, garde can validate the length of these structs.Notes:
AsStr
, e.g.impl HasSimpleLength for <T: AsStr>
. Then we could justimpl AsStr for Url
and unlock more rules forUrl
structs. Even if it's not feasible for length rules, implementingAsStr
forUrl
might be a good addition in a second PR.rules/url
module rather than the individualrules/length
modules, as I think it's worthwile to have all functionality gated behind theurl
feature in one place. If you think it's better the other way around I'll change it.I'm happy to change the approach if you think it makes more sense in another way!