feat: Add conditional validation with if(cond = <expr>, <rules>...) syntax#149
Open
aobatact wants to merge 3 commits intojprochazk:mainfrom
Open
feat: Add conditional validation with if(cond = <expr>, <rules>...) syntax#149aobatact wants to merge 3 commits intojprochazk:mainfrom
if(cond = <expr>, <rules>...) syntax#149aobatact wants to merge 3 commits intojprochazk:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #78
This PR introduces conditional validation functionality to garde, allowing users to apply validation rules only when specific conditions are met. This enables more flexible and dynamic validation logic based on field values or context.
Syntax:
#[garde(if(cond = <expression>, <rules>...))]Alternative Syntaxes Considered
Option 1: Global scope modifier
#[garde(ascii, length(min = 3), if(self.enabled))]This creates ambiguity about which rules the condition applies to and breaks the independence of individual validation rules.
Option 2: Per-rule conditions
#[garde(ascii(if = self.check_ascii), length(min = 3, if = self.check_length))]While this maintains rule independence, it becomes verbose, and less efficient when multiple rules share the same condition.
Option 3: Simple wrapper syntax
#[garde(if(self.enabled, ascii, length(min = 3)))]While simpler, this creates order dependency between the condition and rules.