Draft
Conversation
Add a simple test for async support
Remove unused module Explanation: You are not using Validate::options with type Options field you are using Options struct itself
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in Progress: Experimental Async Support
Async validation was deemed out of scope by the maintainer (see #83). This PR is an experimental async implementation.
Status
inner) is not supportedNotes
Innerdoes not currently work with async.Implementation either relies on generics or duplicates parts of the sync validation logic, which may introduce maintenance issues.
The sync implementation is essentially unchanged; only the parent function now uses the ParentFn type.
Removed unused code:
Feedback would be helpful.