fix(gpu): engine-run route double-prefix + forge control-plane default#631
Merged
Conversation
Two fixes to the server-side engine launch (#630), found in the live smoke: - the route was `@router.post("/gpu/engine/run")` on a router already prefixed `/gpu` → it registered at /gpu/gpu/engine/run (404). Correct to `/engine/run` (full path /api/v1/gpu/engine/run, matching the SDK). - the executor only set FORGE_API_URL when the credential carried one; a bare fg_ token has none, so the forge client fell back to localhost:8080 ("connection refused"). Default to https://forge.shadow-paas.com. Verified live: `gpu engine/run` forge → pi~3.14160, 154x, exit 0. Token never left the server. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes to #630, caught in the live smoke:
@router.post("/gpu/engine/run")on aprefix="/gpu"router → registered at/gpu/gpu/engine/run(404). Now/engine/run→/api/v1/gpu/engine/run(matches the SDK).FORGE_API_URL; a bare token → forge client hitlocalhost:8080(refused). Now defaults tohttps://forge.shadow-paas.com.Verified live end-to-end: server-side
forge runvia/gpu/engine/run→pi~3.14160, 154x, exit 0. Token never left the API/executor. Already hot-patched in prod (bind-mount); this syncs the repo. No SDK change.Note: #629's OVH endpoints have the same double-prefix (
/gpu/ai-training/*) — I'll fix on that branch before it deploys.🤖 Generated with Claude Code