Fix: Ensure validation errors are sorted by schema insertion order #2281
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses #2279 by ensuring that validation errors are returned in the same order as fields are defined in the schema — particularly when multiple nested objects exist at the same level. Previously, validation errors could appear in reverse or unpredictable order due to internal traversal logic.
Problem
When validating schemas with
abortEarly: false
, Yup collects errors from nested objects but does not guarantee that those errors respect the declaration order within the schema. For example:Produces this incorrect error order:
Fix
Highlights
No breaking changes.
Inline and scoped: only affects the error collection phase when abortEarly: false.
Example After Fix
Closes
#2279
Let me know if you'd like to include benchmarks or add a test case into the PR body for reviewers — happy to help tighten it up more!