Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css: Document no auto-appending px in jQuery 4.0 #1261

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

mgol
Copy link
Member

@mgol mgol commented Oct 14, 2024

Also, document the removal of jQuery.cssNumber in jQuery 4.0.

jQuery.cssNumber is a weird API as it was never deprecated since jQuery 3.x uses it but jQuery 4.0.0 will not need it.

@mgol mgol added this to the 4.0.0 milestone Oct 14, 2024
@mgol mgol self-assigned this Oct 14, 2024
@mgol
Copy link
Member Author

mgol commented Oct 14, 2024

This is a new version of #1260.

@timmywil
Copy link
Member

timmywil commented Mar 3, 2025

@mgol mgol force-pushed the jquery-4-cssNumber branch from 48dbb94 to db431f4 Compare March 17, 2025 12:50
@mgol
Copy link
Member Author

mgol commented Mar 17, 2025

Do we want to document this list?

jquery/jquery@447432f/test/unit/css.js#L1281

Done, PTAL.

I grouped the properties into some categories as a list with one property per list item got a bit long.

Screenshot of the proposed state:
Screenshot 2025-03-17 at 13 49 52

@mgol mgol added the Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. label Mar 17, 2025
@timmywil timmywil removed the Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. label Mar 17, 2025
@mgol
Copy link
Member Author

mgol commented Mar 17, 2025

The list re-addded; here's how it looks right now:
Screenshot 2025-03-17 at 18 08 10

I wonder if it'd be better to group by version added instead?

@mgol mgol requested a review from timmywil March 17, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants