Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Remove support for jQuery 4.x #554

Merged
merged 11 commits into from
Feb 18, 2025
Merged

Conversation

mgol
Copy link
Member

@mgol mgol commented Nov 4, 2024

No description provided.

@mgol mgol added this to the 3.6.0 milestone Nov 4, 2024
@mgol mgol requested a review from timmywil November 4, 2024 23:51
@mgol mgol self-assigned this Nov 4, 2024
@mgol mgol marked this pull request as ready for review November 4, 2024 23:56
@mgol mgol force-pushed the 3.x-stable-proposal branch 3 times, most recently from ac75ace to 5336ff5 Compare November 7, 2024 00:41
@mgol mgol force-pushed the 3.x-stable-proposal branch from 5336ff5 to 8761004 Compare November 19, 2024 22:15
@mgol mgol requested a review from gibson042 November 19, 2024 22:17
@mgol mgol force-pushed the 3.x-stable-proposal branch from 8761004 to 3b053e2 Compare December 1, 2024 23:59
@mgol mgol force-pushed the 3.x-stable-proposal branch from 85002ec to 084a64e Compare January 4, 2025 12:57
@mgol mgol force-pushed the 3.x-stable-proposal branch from a86e416 to 8e9b9d0 Compare January 14, 2025 11:32
@mgol mgol added the Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. label Jan 14, 2025
mgol added 10 commits February 2, 2025 13:47
This will save space and avoid potential divergence from Core.

To minimize risk, this only handles APIs still present in jQuery 4.x.
This fixes tests with 3.0/3.1 slim builds.
jQuery <3.2.0 doesn't include the deprecated module in the slim build so it
makes sense to test on one of these versions in slim mode even on PRs.
As of January 2025, iOS 10 is a tier 4 device on BrowserStack:
https://www.browserstack.com/device-tiers
That leads to devices with this iOS version often not being available and
failing our tests. Remove it from the test matrix. Also, add comments explaining
the status of tests on various iOS versions, including iOS 7 that we stopped
testing on a long time ago.

Ref jquery/jquery#5606
Indicate this version of Migrate helps with updating jQuery to 3.x, not 3.0+.
@mgol mgol force-pushed the 3.x-stable-proposal branch from 02c9691 to 4a66dab Compare February 2, 2025 12:47
@timmywil timmywil removed the Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. label Feb 3, 2025
Copy link
Member

@timmywil timmywil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple questions

Copy link
Member

@timmywil timmywil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending the typo fix. Edit: oh, and "latest 3.x build"

@mgol mgol removed the Needs review label Feb 17, 2025
@mgol mgol merged commit 0a61d7d into jquery:3.x-stable Feb 18, 2025
9 checks passed
@mgol mgol deleted the 3.x-stable-proposal branch February 18, 2025 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants