Core: Remove support for jQuery 4.x #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgol
force-pushed
the
3.x-stable-proposal
branch
3 times, most recently
from
ac75ace to
5336ff5
Compare
mgol
force-pushed
the
3.x-stable-proposal
branch
from
5336ff5 to
8761004
Compare
mgol
force-pushed
the
3.x-stable-proposal
branch
from
8761004 to
3b053e2
Compare
mgol
force-pushed
the
3.x-stable-proposal
branch
from
85002ec to
084a64e
Compare
mgol
force-pushed
the
3.x-stable-proposal
branch
from
a86e416 to
8e9b9d0
Compare
mgol
added
the
Discuss in Meeting
This will save space and avoid potential divergence from Core. To minimize risk, this only handles APIs still present in jQuery 4.x.
This fixes tests with 3.0/3.1 slim builds.
jQuery <3.2.0 doesn't include the deprecated module in the slim build so it makes sense to test on one of these versions in slim mode even on PRs.
As of January 2025, iOS 10 is a tier 4 device on BrowserStack: https://www.browserstack.com/device-tiers That leads to devices with this iOS version often not being available and failing our tests. Remove it from the test matrix. Also, add comments explaining the status of tests on various iOS versions, including iOS 7 that we stopped testing on a long time ago. Ref jquery/jquery#5606
Indicate this version of Migrate helps with updating jQuery to 3.x, not 3.0+.
mgol
force-pushed
the
3.x-stable-proposal
branch
from
02c9691 to
4a66dab
Compare
timmywil
removed
the
Discuss in Meeting
timmywil
reviewed
Feb 17, 2025
timmywil
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.