Skip to content

Conversation

@HermitShamiko
Copy link
Contributor

@HermitShamiko HermitShamiko commented Jan 18, 2026

When the screen size is larger than 480px, follow the display style of the PC and place the books in a single line.
befofe:
FY~}1 K0JH$Z~)}M)}@TJ6J
after:
~2@W}0KC0Q@~~)P$UH{NCOS

Optimize footer display on mobile devices
Fixed a bug that caused overflow when the width was too small.
Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I don't think it's the best solution, though. What flex mostly does here is making float: left ineffective, more so than any real flex algorithm.

footer .books li has override styles for max-width: 700px. I checked and 3 books don't fit on the smallest phone screens (like first iPhone SE: 320 px wide) but they do for slightly larger screens.

In the interest of maintainability, I'd rather rework the whole footer .books & .footer .books li styles to remove floats and introduce flexbox with CSS gap, and then on the smallest breakpoints - max-width: 480 px - make it stretch instead.

Let me know if you'd like to work on it.

Rewrite the footer.books layout
@HermitShamiko HermitShamiko requested a review from mgol January 22, 2026 03:39
@HermitShamiko
Copy link
Contributor Author

HermitShamiko commented Jan 22, 2026

Thanks for the PR. I don't think it's the best solution, though. What flex mostly does here is making float: left ineffective, more so than any real flex algorithm.

footer .books li has override styles for max-width: 700px. I checked and 3 books don't fit on the smallest phone screens (like first iPhone SE: 320 px wide) but they do for slightly larger screens.

In the interest of maintainability, I'd rather rework the whole footer .books & .footer .books li styles to remove floats and introduce flexbox with CSS gap, and then on the smallest breakpoints - max-width: 480 px - make it stretch instead.

Let me know if you'd like to work on it.
I have tried rewriting the footer.books layout.
The default (700px is the same):

72RMZMTPT3}5(NY3C9$LS1I U~WUQWU$)F(CZZC%S4A X5U

Below 480, it is not limited to one line:

DS){D@@PL (TI1L5JDG7KOM

Looking forward to your further guidance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants