Add loosely-typed API to construct roslaunch commands#84
Open
tejashah88 wants to merge 4 commits into
Open
Conversation
Contributor
Author
|
I fixed the merge conflicts to match the new format |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello again,
I noticed there's been some activity on the repo and I wanted to add a minor QOL PR to how launch commands are constructed. I didn't like the idea of string concatenating complex arguments so I created
construct_roslaunch_command, which is a simple command to take the ROS module, launch file and launch commands and create the launch command string.The easiest comparision is shown below in
robo_gym/envs/ur/ur_avoidance_basic.py:Before
After
I haven't checked if this PR works cleanly with the new changes but you can use the test file as a starting reference. Let me know your feedback on this!
Tejas