feat(ci): add conditional knip step to ci_npmjs#36
Merged
Conversation
Runs `pnpm knip` in the unit job if the caller's package.json declares a `knip` script. No-op otherwise. Same opt-in pattern as lint/test/build. Caller opt-in is implicit — just add knip as a script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
knipstep to the unit job inci_npmjs.yaml. Runspnpm knipif the caller's
package.jsondeclares aknipscript; otherwise ano-op. Same conditional pattern as lint/test/build/syncpack.
Caller opt-in is implicit — declare a
knipscript inpackage.jsonand the step runs. No new workflow input needed.
Context: WG-34 (knip dead-code detection in whengas-ui). Landing this
here makes the same gate available to any TS repo on the shared workflow.
Test plan
knipscript runspnpm knipknipscript logs skip and passes