fix(workflows): skip empty configFile in lint_commits#39
Merged
Conversation
Passing configFile as empty string made wagoid/commitlint-github-action fail with EISDIR because cosmiconfig treated the workspace directory as a config file path. Use two conditional steps so the input is only forwarded when the caller actually set it; otherwise rely on cosmiconfig auto-detection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
configFile: ''to wagoid action when caller didn't set it, causing EISDIR as cosmiconfig treated the workspace dir as a file pathContext
Failure seen on https://github.com/whengas/whengas-ui/pull/45 (commitlint job):
Test plan