feat(shared): manifest-driven sync script for shared configs#42
Merged
Conversation
Add shared/MANIFEST.json declaring which canonical configs consumer repos should sync, split into two destination modes: - cache: → .shared/<file>, gitignored, re-fetched in CI - committed: → <file> at repo root, must be committed, drift-checked Add shared/sync.sh as the generalised replacement for sync-shared-lint.sh. Driven by MANIFEST.json, so adding new shared configs in future requires only a manifest edit, no script changes. Add shared/release-please-config.json as the canonical release-please config (common across all Python/Node/Go consumers — release-type is supplied by the caller workflow's `with: release-type:` input, so the config itself is language-agnostic). sync-shared-lint.sh left in place for backwards compatibility; consumers will be migrated to sync.sh during the release-please config rollout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shared/MANIFEST.json— declares which canonical configs consumer repos sync, split into two destination modes:cache→.shared/<file>, gitignored, re-fetched in CIcommitted→<file>at repo root, must be committed, drift-checkedshared/sync.sh— generalised, manifest-driven replacement forsync-shared-lint.sh. Adding new shared configs in future = edit manifest, no script change.shared/release-please-config.json— canonical config;release-typestays a caller workflow input, so one config works for Python/Node/Go.Motivation
Seven Python repos just adopted release-please (WG-86) with byte-identical
release-please-config.jsoncopy-pasted into each. As that count grows, keeping them in sync by hand drifts. Same pattern thatsync-shared-lint.shalready solves for lint configs — extend it.Rollout plan
sync.sh, delete in-reporelease-please-config.json(becomes synced).sync-shared-lint.shkept in place for now to avoid breaking existing consumers mid-migration; removed once all consumers are onsync.sh.Test plan
curl -sfL https://raw.githubusercontent.com/jr200-labs/github-action-templates/master/shared/sync.sh | bash -s pythonin a scratch dir — verify it pulls bothrelease-please-config.jsonand.shared/ruff.toml..shared/gets added to.gitignoreif missing.