Fix engine lifecycle and CI sandboxing - #1
Draft
jr4488 wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
postMessagefailuresWhy
Search undo records lost captured-piece state, game-ply accounting was one move ahead, quiescence could search beyond draw limits, and guided-play cancellation left stale worker or UI state. GitHub's Ubuntu 24.04 runners also restrict unprivileged user namespaces through AppArmor, causing the mandatory Bubblewrap integration smoke test to fail before the rest of CI could complete.
Impact
Engine searches now leave positions unchanged, choose moves against the correct game horizon, and recover cleanly from cancellation or worker failure. The CI sandbox remains mandatory while using a targeted AppArmor allowance instead of disabling the host-wide user-namespace restriction.
Validation
npm run verifynpm audit --audit-level=high— 0 vulnerabilitiesgit diff --checkpassedFollow-up
The updated AppArmor setup still needs confirmation from this PR's GitHub-hosted Ubuntu matrix.