Switch from git2 to gitoxide#159
Merged
petersimonsson merged 1 commit intojrmoulton:mainfrom Apr 20, 2025
Merged
Conversation
This removes the need to link against libgit2, however adds a runtime dependency on git, which users should generally have installed In two places a git process is spawned: - when creating a new default worktree (not supported by gitoxide, but also not the common scenario when opening a repo) - when cloning a repo (this is technically supported by gitxode, but adds a lot of complexity for credentials and progress display) These are both one-off commands without any need for integration where we'd have any gain to implementing them in rust
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#156
My attempt at this, with a few caveats:
This removes the need to link against libgit2, however adds a runtime dependency on git, which users should generally have installed
In two places a git process is spawned:
These are both one-off commands without any need for integration where we'd have any gain to implementing them in rust
As I wrote in #156 (comment), performance is massively improved for submodules, otherwise it's not a noticeable difference