More fixes to support Rails 7.2 #1169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sql2 as adapter value
…tests and it's hard to check if transaction is open with jdbc 29) Failure: ActiveRecord::AdapterConnectionTest#test_materialized_transaction_state_can_be_restored_after_a_reconnect [test/cases/adapter_test.rb:543]: Expected false to be truthy. 30) Failure: ActiveRecord::AdapterConnectionTest#test_unmaterialized_transaction_state_can_be_restored_after_a_reconnect [test/cases/adapter_test.rb:577]: Expected false to be truthy. 31) Failure: ActiveRecord::AdapterConnectionTest#test_materialized_transaction_state_is_reset_after_a_reconnect [test/cases/adapter_test.rb:533]: Expected false to be truthy. 32) Failure: ActiveRecord::AdapterConnectionTest#test_materialized_transaction_state_is_reset_after_a_disconnect [test/cases/adapter_test.rb:553]: Expected false to be truthy.
Could not log "sql.active_record" event. NoMethodError: undefined method `value_for_database' for
in the server we can use queries such as: ``` SELECT * FROM pg_stat_activity WHERE datname = 'dbname'; ```
…e as CRuby adapter)" This is causing a mutex relocking issue This reverts commit a46bc66.
|
I reverted one commit that is causing mutex re-locking issue look at it later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @enebo
Here is more fixes for the adapter.
I reckon the support for sqlite and Mysql is decent with exception the message pack support.
there are over 20 mysql compatibility tests failing which is not due to the adapter but to AR tests.
all of them pass with: