1.2.x: Back-port JRuby 10 and Rails 8.0 compatibility#360
Closed
chadlwilson wants to merge 6 commits into
Closed
Conversation
…or supported JRubies This has been set to 2.1 for all supported JRubies for a long time, and the setting did nothing within JRuby. This cherry-pick avoids changing the API by bringing the class over from JRuby, allowing compatibility with JRuby 10. (cherry picked from commit abc7e0b) # Conflicts: # README.md # src/main/java/org/jruby/rack/DefaultRackConfig.java # src/main/java/org/jruby/rack/embed/Config.java # src/spec/ruby/jruby/rack/integration_spec.rb # src/spec/ruby/rack/application_spec.rb # src/spec/ruby/rack/config_spec.rb
(cherry picked from commit d794a22) # Conflicts: # .github/workflows/maven.yml # CHANGELOG.md # README.md # pom.xml # src/main/ruby/jruby/rack/version.rb
(cherry picked from commit 854c086) # Conflicts: # .github/workflows/maven.yml # gemfiles/rails50.gemfile.lock # gemfiles/rails52.gemfile.lock # gemfiles/rails60.gemfile.lock # gemfiles/rails61.gemfile.lock # gemfiles/rails70.gemfile.lock # gemfiles/rails71.gemfile.lock # gemfiles/rails72.gemfile.lock # gemfiles/rails80.gemfile.lock
(cherry picked from commit c18d0f7)
(cherry picked from commit 7e9bb85)
Must have been a cherry-pick go a bit wild here somewhere.
Contributor
Author
kares
reviewed
Oct 12, 2025
This was referenced Apr 16, 2026
chadlwilson
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #273, #299, #314 to the
1.2.xbranch by housing the JRuby-10-removedCompatVersionclass (used byRackConfigAPI), and avoiding needing to change the jruby-rack API.Generally 1.2.x was already working with JRuby 10 if the Config was not used in certain ways causing the
CompatVersionclass to be loaded; and if there were not failures during initialization that cause reflection on theRackConfigto be able to dump to logging.This will make it easier for folks to move to JRuby 10 within Warbler without having to move to jruby-rack
1.3.Since
CompatVersionhas been a no-op on JRuby itself for a very long time, removing the actual implementation does no harm.jruby.compat.versionjruby-rack init properly will just be ignored, and the default values from earlier returned.