chore: relax rubyzip requirement to allow rubyzip 2.x #592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only change with our rubyzip 3 upgrade was to use keyword arg `create: true` rather than positional `create = true`. Support for this was added in rubyzip 2.1.0 (https://github.com/rubyzip/rubyzip/releases/tag/v2.1.0) via rubyzip/rubyzip#418 so we don't need such a strict requirement on 3.x. The other breaking changes in rubyzip 3.0 don't appear to be important for warbler: https://github.com/rubyzip/rubyzip/wiki/Updating-to-version-3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only change with our rubyzip 3 upgrade in #571 was to use keyword arg
create: truerather than positionalcreate = true.Support for keyword args like this was added in rubyzip 2.1.0 (https://github.com/rubyzip/rubyzip/releases/tag/v2.1.0) via rubyzip/rubyzip#418 so we don't need such a strict requirement on 3.x. The other breaking changes in rubyzip 3.0 don't appear to be important for warbler: https://github.com/rubyzip/rubyzip/wiki/Updating-to-version-3.x
Manually tested this via RubyZip 2.x locally via
bundle exec rake spec integrationwith JRuby 9.4 and works fine.