Skip to content

Conversation

@genius192x
Copy link
Contributor

No description provided.

@jsru-1
Copy link
Contributor

jsru-1 commented Apr 6, 2025

Добавляю преподавателя (@ShGKme) для код-ревью.

@jsru-1 jsru-1 requested a review from ShGKme April 6, 2025 16:44
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Принято, но обратите внимание на комментарий


// Обработчики кнопок
function getNext() {
if (meetupId.value < 5) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Можно не добавлять проверки в эти функции, так как они уже покрыты disabled

<button
class="button button--secondary"
@click="getPrevious"
:disabled="canGetPrevious || loading"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Хорошая идея, выключать кнопки при загрузке 👍

@jsru-1 jsru-1 merged commit 8756fbc into js-tasks-ru:master Apr 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants