fix: update continent and region on country change

[MartinKolarik]

Fixes #652.

[coderabbitai]

Walkthrough

The changes expand the functionality of the getUpdatedLocation method within the AdoptedProbes class. Two new functions, getContinentByCountry and getRegionByCountry, are imported and used to derive the continent and region from the country code of an adopted probe. The returned location object now includes continent and region properties, populated using these functions. Correspondingly, the unit test for getUpdatedLocation is updated to use a probe in Greenland, with expected outputs reflecting the new continent ("NA") and region ("Northern America") fields, along with updated country, city, and coordinates. No changes were made to the public API or exported signatures.

Assessment against linked issues

Objective	Addressed	Explanation
Ensure continent is updated when country override is applied (#652)	✅
Add region information based on country in updated location (#652)	✅

Possibly related PRs

• feat: allow probe country change #644: Modifies AdoptedProbes types and logic for country changes and custom locations, directly relating to location handling updates in this PR.

Poem

In code we roam from land to land,
Greenland's chill now close at hand.
Continent and region join the show,
With country codes, the data flow.
Probes adopted, maps aligned—
Location’s tale, more well-defined!
🌎✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 24c4254 and 1b28415.

📒 Files selected for processing (2)

• src/lib/override/adopted-probes.ts (2 hunks)
• test/tests/unit/override/adopted-probes.test.ts (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

`**/*.{vue,ts,js}`: We use Nuxt with auto imports enabled. Don't warn about missing imports.

**/*.{vue,ts,js}: We use Nuxt with auto imports enabled. Don't warn about missing imports.

• src/lib/override/adopted-probes.ts
• test/tests/unit/override/adopted-probes.test.ts

🧬 Code Graph Analysis (2)

src/lib/override/adopted-probes.ts (1)

src/lib/location/location.ts (2)

• getContinentByCountry (26-34)
• getRegionByCountry (16-24)

test/tests/unit/override/adopted-probes.test.ts (1)

src/lib/ws/server.ts (1)

• adoptedProbes (109-109)

⏰ Context from checks skipped due to timeout of 90000ms (4)

• GitHub Check: Run e2e tests
• GitHub Check: Run tests
• GitHub Check: Run tests
• GitHub Check: Run e2e tests

🔇 Additional comments (5)

src/lib/override/adopted-probes.ts (2)

9-9: Import statement includes the necessary utility functions.

The code correctly imports getContinentByCountry and getRegionByCountry functions to derive continent and region information based on a country code.

---

192-193: Continent and region are now properly derived from country code.

The implementation correctly uses the imported utility functions to populate continent and region values in the returned location object, ensuring they stay in sync when country changes.

test/tests/unit/override/adopted-probes.test.ts (3)

989-994: Test data properly updated to use Greenland location.

The test now uses Nuuk, Greenland (GL) instead of the previous Ireland location, providing better test coverage for different continent/region values.

---

1005-1012: Test correctly includes Greenland in allowed countries.

The test case properly updates the allowed countries array to include both 'IE' and 'GL', ensuring the location update logic can be tested.

---

1014-1027: Test assertion verifies continent and region values.

The test's expected result now correctly includes and verifies the 'continent' (NA) and 'region' (Northern America) properties, properly validating the implementation.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.