fix: use measurementId as location after offloading#801
fix: use measurementId as location after offloading#801alexey-yarmosh wants to merge 1 commit intomasterfrom
Conversation
WalkthroughThis PR introduces centralized measurement retrieval logic in Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/measurement/store.ts (1)
71-101:⚠️ Potential issue | 🟡 MinorAdd offloader support to
getMeasurementsfor fallback retries.The bulk
getMeasurementsmethod (line 103-105) queries only Redis and lacks offloader support. When a database insert fails and triggers a fallback retry (lines 119-127 in store-offloader.ts),insertBatchToDbByIdscallsgetMeasurementsto re-fetch those measurements (line 177). For measurements older than 30 minutes that have already been offloaded to the database, this query will return null values and the retry will fail.
Fixes #783