Document createGenericPropertyDescriptor #299
Open
+9
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asamuzaK
reviewed
Jan 11, 2026
| const { AST_TYPES } = parsers; | ||
|
|
||
| /** | ||
| * Creates a generic property descriptor for the `CSSStyleDeclaration` class for a given property. Such descriptors are |
Contributor
There was a problem hiding this comment.
Suggested change
| * Creates a generic property descriptor for the `CSSStyleDeclaration` class for a given property. Such descriptors are | |
| * Creates a generic property descriptor for a given property. Such descriptors are |
We will remove properties from CSSStyleDeclaration on next major release.
Contributor
|
LGTM with nit addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #280.
@asamuzaK can you check my description? As mentioned in #295 (comment) I am not 100% sure on our eventual plans for when we use handlers vs. when we use createGenericPropertyDescriptor() or some other framework.