chore: merge 0.2.2 hotfix back into main#56
Merged
Conversation
Django 6.0 dropped the top-level id/name/geom_type template-context variables from BaseGeometryWidget (they moved under 'widget'). The map widget template reads them at the top level, so the hidden geometry input rendered with an empty name (no geometry submitted) and the map container with an empty data-field-id (the JS bailed, no map). Re-expose them in PathwaysMapWidget.get_context; stays compatible with Django 5.2. Fixes #52
# Conflicts: # CHANGELOG.md
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #56 +/- ##
==========================================
+ Coverage 73.40% 73.42% +0.02%
==========================================
Files 52 52
Lines 5189 5193 +4
==========================================
+ Hits 3809 3813 +4
Misses 1380 1380 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[Unreleased]for the next (0.3.0) release.Changes
netbox_pathways/forms.py:PathwaysMapWidget.get_contextre-exposes theid/name/geom_typetemplate-context vars that Django 6.0 dropped fromBaseGeometryWidget.tests/test_map_widget.py: regression tests for the widget render.CHANGELOG.md: new## [0.2.2] - 2026-06-30section (Fixed [Bug]: Structure Location does not show maps after a clean install #52);[Unreleased]features preserved.README.md,docs/index.md: NetBox 4.6 / Django 6.0 compatibility notes.release/0.2.2).Testing
ruff checkpassesruff format --checkpassespytestpasses locally (459 + 3 new, on NetBox 4.6.3 / Django 6.0.6)Related
Refs: #52