Skip to content

Fix stateful NON_LATIN1_REGEXP in createparams #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deepview-autofix wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix stateful NON_LATIN1_REGEXP in createparams #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/create.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,3 +307,16 @@ describe('create(filename, options)', function () {
});
});
});

describe('create() regex state bug', function () {
it('should still throw on second call with non-ISO-8859-1 fallback', function () {
assert.throws(
create.bind(null, 'file.pdf', { fallback: '€ rates.pdf' }),
/fallback.*iso-8859-1/i,
);
assert.throws(
create.bind(null, 'file.pdf', { fallback: '€' }),
/fallback.*iso-8859-1/i,
);
});
});
7 changes: 5 additions & 2 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,8 +232,11 @@ function createparams(
throw new TypeError('fallback must be a string or boolean');
}

if (typeof fallback === 'string' && NON_LATIN1_REGEXP.test(fallback)) {
throw new TypeError('fallback must be ISO-8859-1 string');
if (typeof fallback === 'string') {
NON_LATIN1_REGEXP.lastIndex = 0;
if (NON_LATIN1_REGEXP.test(fallback)) {
throw new TypeError('fallback must be ISO-8859-1 string');
}
}

const params: Record<string, string> = new NullObject();
Expand Down